[Bug 21519] New: Mass Effect 2 crashes after start

http://bugs.winehq.org/show_bug.cgi?id=21519
Summary: Mass Effect 2 crashes after start
Product: Wine
Version: 1.1.37
Platform: x86
URL: http://masseffect.bioware.com
OS/Version: Linux
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: directx-d3d
AssignedTo: wine-bugs@winehq.org
ReportedBy: andras@csevego.net
CC: hverbeet@gmail.com
Created an attachment (id=25919)
--> (http://bugs.winehq.org/attachment.cgi?id=25919)
output without any extended debug option
If you start Mass Effect 2, it will crash with newest wine. It's a regression,
because somebody reported, it is working with version 1.1.21 of wine.
I did a bisect, that shows the problematic commit is:
--
author Henri Verbeet
Thu, 11 Jun 2009 08:24:30 +0000 (10:24 +0200)
committer Alexandre Julliard
Thu, 11 Jun 2009 09:53:55 +0000 (11:53 +0200)
commit 5fbf895da683c21a89ad6a5e1433279c241b564f
tree 6b606159d92bb69e8c186440d4e6d1f63f592c31 tree | snapshot
parent da12ac05a4a5fe857fa317fbdbbb2ccce12b838a commit | diff
wined3d: Use the format info to calculate compressed surface pitch in
IWineD3DBaseSurfaceImpl_GetPitch().
--
I reverted this patch manually, and game started. I can confirm the problem is
the new pitch calculation.
CCing Henri Verbeet.
--
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.

http://bugs.winehq.org/show_bug.cgi?id=21519
Dmitry Timoshkov changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |regression

--
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.

http://bugs.winehq.org/show_bug.cgi?id=21519

--- Comment #1 from Henri Verbeet 2010-01-29 05:54:47 ---
Could you attach a +d3d,+d3d_surface log?
--
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.

http://bugs.winehq.org/show_bug.cgi?id=21519

--- Comment #2 from Andras Kovacs 2010-01-29 06:55:39 ---
Created an attachment (id=25938)
--> (http://bugs.winehq.org/attachment.cgi?id=25938)
+d3d, +d3d_surface trace
--
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.

http://bugs.winehq.org/show_bug.cgi?id=21519

--- Comment #3 from Henri Verbeet 2010-01-29 11:27:04 ---
It seems to be using ATI2N, which was previously not handled as a compressed
format. As far as I can see the reported pitch of 512 is correct for a 128x128
texture of that format though.
--
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.

http://bugs.winehq.org/show_bug.cgi?id=21519
knipl@in.tum.de changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |knipl@in.tum.de

--
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.

http://bugs.winehq.org/show_bug.cgi?id=21519
Cuchac changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |cuchac@email.cz

--- Comment #4 from Cuchac 2010-02-02 15:18:18 ---
Same here.
ME2 crashes and after reverting the commit everything is smooth.
I've compared return values of IWineD3DBaseSurfaceImpl_GetPitch() before and
after patch and the results are the same (until the crash). I can't see why it
is page-faulting.
--
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.

http://bugs.winehq.org/show_bug.cgi?id=21519

--- Comment #6 from Cuchac 2010-02-02 16:45:50 ---
Created an attachment (id=26032)
--> (http://bugs.winehq.org/attachment.cgi?id=26032)
Revert commit 5fbf895da683c21a89ad6a5e1433279c241b564f
--
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.

http://bugs.winehq.org/show_bug.cgi?id=21519
jonathan strander changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mblackwell1024@gmail.com

--- Comment #7 from jonathan strander 2010-02-02 22:26:43 ---
(In reply to comment #6)
> Created an attachment (id=26032)
--> (http://bugs.winehq.org/attachment.cgi?id=26032) [details]
> Revert commit 5fbf895da683c21a89ad6a5e1433279c241b564f
Using the above patch with v1.1.37 causes numerous graphical artifacts. v1.1.22
doesn't have them.
--
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.

http://bugs.winehq.org/show_bug.cgi?id=21519

--- Comment #8 from jonathan strander 2010-02-06 17:38:09 ---
(In reply to comment #7)
> (In reply to comment #6)
> > Created an attachment (id=26032)
--> (http://bugs.winehq.org/attachment.cgi?id=26032) [details] [details]
> > Revert commit 5fbf895da683c21a89ad6a5e1433279c241b564f
>
> Using the above patch with v1.1.37 causes numerous graphical artifacts. v1.1.22
> doesn't have them.
Here's an example of the graphical glitches present using a patched v1.1.37.
http://mb.mirage.org/bugzilla/me2screenshot1.png
http://mb.mirage.org/bugzilla/me2screenshot2.png
http://mb.mirage.org/bugzilla/me2screenshot3.png
As you can see, textures have those odd patches, and the lighting on character
models (the player especially) is oddly blocky. Additionally, lights that are
out of view in relation to the camera flicker out, causing the world to be
dark.
--
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.

http://bugs.winehq.org/show_bug.cgi?id=21519

--- Comment #9 from jonathan strander 2010-02-08 09:10:15 ---
(In reply to comment #8)
> (In reply to comment #7)
> > (In reply to comment #6)
> > > Created an attachment (id=26032)
--> (http://bugs.winehq.org/attachment.cgi?id=26032) [details] [details] [details]
> > > Revert commit 5fbf895da683c21a89ad6a5e1433279c241b564f
> >
> > Using the above patch with v1.1.37 causes numerous graphical artifacts. v1.1.22
> > doesn't have them.
>
> Here's an example of the graphical glitches present using a patched v1.1.37.
>
> http://mb.mirage.org/bugzilla/me2screenshot1.png
> http://mb.mirage.org/bugzilla/me2screenshot2.png
> http://mb.mirage.org/bugzilla/me2screenshot3.png
>
> As you can see, textures have those odd patches, and the lighting on character
> models (the player especially) is oddly blocky. Additionally, lights that are
> out of view in relation to the camera flicker out, causing the world to be
> dark.
Scratch that. Updating the NVIDIA Binary driver from 195.30 to 195.36.03 fixed
this in v1.1.38 (where it was still present), meaning it is unrelated.
--
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.