Re: [PATCH] PCAP misc input driver (for 2.6.32)

Em Dom, 2009-06-28 =C3=A0s 23:14 -0700, Dmitry Torokhov escreveu:
> > drivers/input/keyboard/Kconfig | 7 ++
> > drivers/input/keyboard/Makefile | 1 +
> > drivers/input/keyboard/pcap_keys.c | 152 ++++++++++++++++++++++++++++=
++++++++
> > 3 files changed, 160 insertions(+), 0 deletions(-)
> >=20
>=20
> First of all I think the driver should live in misc, not in keyboard,
> since it is not a full-fledged keyboard.
Ok.
> > + Say Y here if you want to use power key and jack events
> > + on Motorola EZX 2nd generation phones
> > +
>=20
> To compile this driver as a module...
Ok.
> > + case PCAP_IRQ_MIC:
> > + input_report_key(pcap_keys->input, KEY_HP, !pstat);
>=20
> Why not SW_MICROPHONE_INSERT?
Its actually a button.
The device has a single jack for headphone and microphone. And the
headset that we connect to it has a button that you use to answer calls,
or dial.
> > +static int __init pcap_keys_probe(struct platform_device *pdev)
>=20
> __devinit, not __init should be used on driver's probe() methods.
Ok.
> > + pcap_keys->input->name =3D pdev->name;
> > + pcap_keys->input->phys =3D "pcap-keys/input0";
> > + pcap_keys->input->dev.parent =3D &pdev->dev;
>=20
> I do like a temp for input_dev, it usually makes code a bit smaller.
> Also it would be nice to have but type set (BUS_HOST I think).
Ok.
> > + set_bit(KEY_HP, pcap_keys->input->keybit);
> __set_bit() please, like Trolok said.
Ok.
> > +static int pcap_keys_remove(struct platform_device *pdev)
>=20
> __devexit here.
Ok.
> > + .remove =3D pcap_keys_remove,
>=20
> __devexit_p()
Ok.
> > +MODULE_DESCRIPTION("Motorola PCAP2 input events driver");
> > +MODULE_AUTHOR("Ilya Petrov ");
> > +MODULE_LICENSE("GPL");
>=20
> Do we need MODULE_ALIAS() here?
Do we? I think we don't, but well... It costs nothing. ;)
--=20
Daniel Ribeiro