Re: [PATCH] PCAP misc input driver (for 2.6.32)

Em Dom, 2009-06-28 =C3=A0s 12:49 +0530, Trilok Soni escreveu:
> > + pcap_keys->input->evbit[0] =3D BIT_MASK(EV_KEY) | BIT_MASK(EV_S=
W);
> > + set_bit(KEY_POWER, pcap_keys->input->keybit);
> > + set_bit(SW_HEADPHONE_INSERT, pcap_keys->input->swbit);
> > + set_bit(KEY_HP, pcap_keys->input->keybit);
>=20
> __set_bit please.
Ok.
> > +
> > + err =3D request_irq(pcap_to_irq(pcap_keys->pcap, PCAP_IRQ_ONOFF=
),
> > + pcap_keys_handler, 0, "Power key", pcap_keys);
> > + if (err)
> > + goto fail_dev;
> > +
> > + err =3D request_irq(pcap_to_irq(pcap_keys->pcap, PCAP_IRQ_HS),
> > + pcap_keys_handler, 0, "Headphone jack", pcap_ke=
ys);
> > + if (err)
> > + goto fail_pwrkey;
> > +
> > + err =3D request_irq(pcap_to_irq(pcap_keys->pcap, PCAP_IRQ_MIC),
> > + pcap_keys_handler, 0, "MIC jack/button", pcap_k=
eys);
> > + if (err)
> > + goto fail_jack;
> > +
> > + err =3D input_register_device(pcap_keys->input);
> > + if (err)
> > + goto fail_mic;
>=20
> Same comment as given in PCAP touchscreen driver.
Ok.
> > +static struct platform_driver pcap_keys_device_driver =3D {
> > + .probe =3D pcap_keys_probe,
> > + .remove =3D pcap_keys_remove,
>=20
> __devexit_p ?
Ok.
Thanks for the review, I will send new versions addressing your comments
as soon as possible.
--=20
Daniel Ribeiro